chore(analysis): remove legacy ana and analytic directories#327
Conversation
Drop obsolete analysis and geometry helper scripts that are no longer part of the supported workflow. This trims repository maintenance surface and removes a large amount of unused legacy tooling.
|
@ggalgoczi Please let me know if you need or use any of the removed scripts in this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50848e0e58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,159 +0,0 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
This commit deletes ana/enum_.py (and also ana/OpticksPhoton.py), but sysrap/CMakeLists.txt still defines ALL custom targets that execute ${ANADIR}/enum_.py and ${ANADIR}/OpticksPhoton.py (I checked lines 496, 510, 529, and 546 in that file). In a normal SysRap build from a clean checkout, those commands will fail with missing-file errors, so the build pipeline is left in a broken state unless the CMake targets are updated in the same change.
Useful? React with 👍 / 👎.
| return "\n".join(lines) | ||
|
|
||
|
|
||
| class Fold(object): |
There was a problem hiding this comment.
Removing ana/fold.py leaves many remaining Python entry points unable to import (for example sysrap/sevt.py and numerous *_test.py scripts still do from opticks.ana.fold import Fold). Any workflow that runs those scripts now will raise ModuleNotFoundError immediately, so this deletion needs either a compatibility shim or coordinated import migration in the same commit.
Useful? React with 👍 / 👎.
No, I do not use any of these scripts. Thank you for refactoring. However I see the sysrap/CMakeLists.txt:514–560 has three add_custom_target(… ALL …) rules invoking removed scripts in current file. |
ggalgoczi
left a comment
ggalgoczi
left a comment
There was a problem hiding this comment.
No, I do not use any of these scripts. Thank you for refactoring.
However I see the sysrap/CMakeLists.txt:514–560 has three add_custom_target(… ALL …) rules invoking removed scripts in current file.
Drop obsolete analysis and geometry helper scripts that are no longer part of the supported
workflow. This trims repository maintenance surface and removes a large amount of unused legacy
tooling.