ci: move Spack install validation off PRs#356
Merged
Conversation
- Remove the PR-triggered Spack install workflow. - Keep Spack dependency buildcache refresh and Simphony source install validation in the scheduled/manual buildcache workflow. - Add the installed-prefix smoke check to the buildcache workflow so it confirms the default `simphony` package selected from `BNLNPPS/spack-packages` installs successfully.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts Spack install validation away from pull-request CI and consolidates it into the scheduled/manual buildcache workflow, so Spack buildcache refresh and “install from source” verification run together.
Changes:
- Removed the pull_request-triggered Spack install workflow.
- Updated the scheduled/manual buildcache workflow to also install
simphonyfrom source (after dependency buildcache refresh). - Added a smoke check in the buildcache workflow to confirm the installed
simphonyprefix exists and contains a recorded Spack spec.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/build-push-spack-buildcache.yaml |
Adds an installed-prefix/spec smoke check after the source install of simphony in the buildcache refresh workflow. |
.github/workflows/build-pull-request-spack.yaml |
Removes PR-triggered Spack install validation workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scheduled/manual buildcache workflow.
simphonypackage selected fromBNLNPPS/spack-packagesinstalls successfully.