ci: consolidate PR image build matrix#398
Open
plexoos wants to merge 2 commits into
Open
Conversation
Share one supported image configuration matrix across release and develop PR image builds so CUDA, OptiX, Geant4, CMake, and OS combinations stay aligned. Add the missing CUDA 12.5.1 release configuration and CUDA 13.2.0 develop configuration. Reuse the shared matrix for PR image testing and cleanup so build, test, and cleanup jobs operate on the same image variants.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pull request image workflow to use a shared build configuration matrix across release and develop image variants, aiming to keep CUDA/OptiX/Geant4/CMake/OS combinations aligned between build, test, and cleanup stages.
Changes:
- Consolidates the PR image build matrix into a shared
configlist and combines it with atarget: [release, develop]axis. - Expands PR image testing and cleanup to operate across both targets (with a GPU-runner OptiX 9.1.0 exclusion for testing).
- Adds the missing CUDA 12.5.1
releasevariant and CUDA 13.2.0developvariant via the shared matrix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type=registry,ref=${{ env.BASE_CACHE_REF }} | ||
| type=registry,ref=${{ env.CACHE_REF }} | ||
| push: ${{ matrix.target == 'develop' && github.event.pull_request.head.repo.full_name == github.repository }} | ||
| push: ${{ github.event.pull_request.head.repo.full_name == github.repository }} |
Comment on lines
186
to
+188
| cleanup-pr-images: | ||
| if: ${{ success() && github.event.pull_request.head.repo.full_name == github.repository }} | ||
| needs: test-develop-image | ||
| needs: test-image |
Run cleanup-pr-images with always() so GHCR PR image cleanup is attempted even when build or test matrix entries fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share one supported image configuration matrix across release and develop PR
image builds so CUDA, OptiX, Geant4, CMake, and OS combinations stay aligned.
Add the missing CUDA 12.5.1 release configuration and CUDA 13.2.0 develop
configuration. Reuse the shared matrix for PR image testing and cleanup so
build, test, and cleanup jobs operate on the same image variants.