Don't do self auto-update, just check for the available updated version #9
Merged
Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes self-update functionality from the BOINC BUDA Runner WSL Installer, changing it to only check for and notify about available updates. It also adds a new "Open Log" button for easier access to log files.
- Disabled automatic self-update; installer now only checks for and notifies about available updates
- Added new "Open Log" button to provide users access to debug logs
- Removed auto-update infrastructure including download and batch file execution logic
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MainWindow.xaml.cs | Modified update check logic to inform rather than perform updates, added log file opening functionality |
| MainWindow.xaml | Added "Open Log" button to the UI layout |
Comments suppressed due to low confidence (2)
MainWindow.xaml.cs:1
- The System.IO import is removed but line 817 uses System.IO.File.Exists(). This will cause a compilation error. Either restore the using statement or use the fully qualified name System.IO.File.Exists().
// This file is part of BOINC.
MainWindow.xaml.cs:480
- The CheckApplicationUpdateAsync method now always returns false, making this conditional check and early return unreachable. Consider removing this logic since self-update is disabled.
var updateTriggered = await CheckApplicationUpdateAsync();
if (updateTriggered)
{
DebugLogger.LogInfo("Update triggered, stopping further processing", "MainWindow");
return; // The app will close; updater will restart the new version
}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore vim swp files, remove accidentally added swp file.
Add new 'Open log' button.