[Client] Add alert if idle time to resume computing is greater than idle time to suspend computing#5270
Merged
davidpanderson merged 4 commits intoBOINC:masterfrom Jun 15, 2023
Conversation
…ter than idle time to suspend computing. Partial fix to BOINC#4939
Contributor
Author
Contributor
|
I'd shorten it to: Preference settings don't allow computing (9.00 > 8.00). Please review. The numbers tell the user which prefs we're talking about. |
Member
|
I agree: the message should be definitely shorter than now, and shows which numbers are not correct. |
If statement was missing that suspend_if_no_recent_input has to be enabled. Also revised message to be shorter.
Contributor
Author
|
Great suggestion, thank you! See revised: I also noticed I missed in my logic that suspend if no recent input had to be enabled, too. That is fixed in the latest commit. Hmm... @davidpanderson, I see in the event log that the two times have different significant digits, %.1f and %f, respectively. I used %.2f for the alert. Do you think we should have these match? |
Contributor
|
It might be good to use %.2f for minutes, everywhere. |
Contributor
Author
Fixed. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Partially fixes #4939
Description of the Change
When global preferences are read in the client, a check is in place to see if the idle time to resume computing is greater than the idle time to suspend computing, but only if CPU or GPU computing is to be suspended when the computer is in use. If this condition is true, CPU or GPU computing could be suspended indefinitely regardless of the activity of the computer. This check will send an alert to the user to make them aware.
Alternate Designs
Previous ideas were discussed in #4960, but this was favored since it did not modify preferences. Thank you to @AenBleidd and @davidpanderson for the feedback!
Release Notes
[Client] Alert added if idle time to resume computing exceeds idle time to suspend computing.