client: avoid erroneous 'suspended - non-BOINC CPU' when running Docker apps#6403
Merged
client: avoid erroneous 'suspended - non-BOINC CPU' when running Docker apps#6403
Conversation
rather than by trying to figure out which processes are Docker apps
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines CPU time accounting for BOINC by excluding Docker apps and including WSL (“vmmem”) processes on Windows, thereby preventing incorrect "suspended" states. Key changes include:
- Adding detailed comments and logic to distinguish Docker/VM processes.
- Introducing new flags (is_vbox_app and is_docker_app) for more precise process categorization.
- Adjusting CPU time calculation to include both user and kernel times for BOINC-related processes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/procinfo_unix.cpp | Added comments to clarify the parsing of /proc//stat files. |
| lib/procinfo.cpp | Updated CPU time calculation and refined comments regarding BOINC and other processes. |
| client/client_types.h | Renamed flags and added a new flag for Docker app identification. |
| client/client_types.cpp | Adjusted the initialization and parsing logic to set the new flags. |
| client/app.cpp | Updated logic to account for Docker apps’ CPU time and use the new flag. |
Comments suppressed due to low confidence (2)
client/client_types.cpp:915
- The removal of the 'vboxwrapper' check may affect the identification of VBox applications. Verify if this change is intentional and, if needed, add analogous logic to set the is_vbox_app flag.
int retval = file_ref.parse(xp);
lib/procinfo.cpp:201
- Consider clarifying in the comment why kernel_time is now added along with user_time for BOINC-related CPU calculation on Windows.
sum += (p.user_time + p.kernel_time);
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
added a commit
that referenced
this pull request
Jul 15, 2025
client: avoid erroneous 'suspended - non-BOINC CPU' when running Docker apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Win: count 'vmmem' (WSL process) as BOINC
Others: get Docker app CPU time from the apps themselves
Fixes #6398 (not tested on linux/mac)