web (job submission): enhancements

[davidpanderson]

• show completion (or abort) time in batch lists
• allow ordering of batch lists by asc/desc submit time or completion time

[Copilot]

Pull Request Overview

This PR enhances the batch listing page by adding completion/abort timestamps to the tables and enabling users to sort batches by submission or completion time.

• Added order controls (order_options, order_item, order_clause, get_order) to generate sort links
• Updated batch tables (show_complete, show_aborted) to display completion_time
• Modified handlers (handle_show_status, handle_admin_*, handle_show_all) to apply dynamic ORDER BY clauses based on user selection

Comments suppressed due to low confidence (2)

html/user/submit.php:63

• [nitpick] Consider adding a doc comment explaining the purpose and parameters of order_options, order_item, order_clause, and get_order for better maintainability.

function order_options($url_args, $order) {

html/user/submit.php:60

• No automated tests were added to cover the new sorting UI and SQL ordering logic; consider adding unit or functional tests to verify each order option.

// sub_asc, sub_desc: submission time ( = ID order)

[Copilot]

Wrap the href value in quotes and escape the URL (e.g. htmlspecialchars()) to avoid malformed HTML and potential XSS vulnerabilities.

[Copilot]

Add a default case or fallback return value in order_clause to guard against unexpected order inputs, preventing invalid SQL syntax.