client: link to platform-specific wiki pages about Docker#6421
Merged
client: link to platform-specific wiki pages about Docker#6421
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Docker installation links to platform-specific wiki pages and integrates them into client notifications.
- Replaces generic Docker URL with Windows-specific link in WSL messages.
- Adds platform-specific Docker installation URLs (Windows, Mac, Linux) in client_state initialization.
- Refactors message printing to use a shared
urlvariable and updates NOTICE link assignments.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| client/hostinfo_wsl.cpp | Updated Docker install URL and adjusted notification text. |
| client/client_state.cpp | Added platform-specific URLs and used them in messages and NOTICE. |
Comments suppressed due to low confidence (2)
client/hostinfo_wsl.cpp:441
- The notification in show_wsl_messages now mentions Docker instead of WSL, which may confuse users. If the intent is to guide WSL setup, restore the WSL-specific messaging or move this Docker instruction to a more appropriate location.
"Some BOINC projects require Docker. <a href=%s>Learn how to install it</a>",
client/client_state.cpp:947
- The string concatenation is invalid and will not compile. Consider using proper escaping and std::string concatenation, for example:
n.description = std::string("Some projects require Docker. ... <a href=\"") + url + "\">here</a>"; n.description = "Some projects require Docker. We recommend that you install it. Instructions are <a href=" + (string)url + (string)">here</a>.";
Comment on lines
+932
to
+938
| #ifdef _WIN32 | ||
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows"; | ||
| #elif defined(__APPLE__) | ||
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac"; | ||
| #else | ||
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux"; | ||
| #endif |
There was a problem hiding this comment.
[nitpick] These platform-specific URLs are repeated; consider centralizing them in a constant map or helper function to reduce duplication and ease future updates.
Suggested change
| #ifdef _WIN32 | |
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows"; | |
| #elif defined(__APPLE__) | |
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac"; | |
| #else | |
| const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux"; | |
| #endif | |
| const char* url = get_docker_install_url(); |
AenBleidd
approved these changes
Jul 9, 2025
AenBleidd
added a commit
that referenced
this pull request
Jul 15, 2025
client: link to platform-specific wiki pages about Docker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.