Skip to content

client: link to platform-specific wiki pages about Docker#6421

Merged
AenBleidd merged 1 commit intomasterfrom
dpa_docker19
Jul 9, 2025
Merged

client: link to platform-specific wiki pages about Docker#6421
AenBleidd merged 1 commit intomasterfrom
dpa_docker19

Conversation

@davidpanderson
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 9, 2025 07:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Docker installation links to platform-specific wiki pages and integrates them into client notifications.

  • Replaces generic Docker URL with Windows-specific link in WSL messages.
  • Adds platform-specific Docker installation URLs (Windows, Mac, Linux) in client_state initialization.
  • Refactors message printing to use a shared url variable and updates NOTICE link assignments.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
client/hostinfo_wsl.cpp Updated Docker install URL and adjusted notification text.
client/client_state.cpp Added platform-specific URLs and used them in messages and NOTICE.
Comments suppressed due to low confidence (2)

client/hostinfo_wsl.cpp:441

  • The notification in show_wsl_messages now mentions Docker instead of WSL, which may confuse users. If the intent is to guide WSL setup, restore the WSL-specific messaging or move this Docker instruction to a more appropriate location.
            "Some BOINC projects require Docker.  <a href=%s>Learn how to install it</a>",

client/client_state.cpp:947

  • The string concatenation is invalid and will not compile. Consider using proper escaping and std::string concatenation, for example:
n.description = std::string("Some projects require Docker. ... <a href=\"") + url + "\">here</a>";
        n.description = "Some projects require Docker.  We recommend that you install it.  Instructions are <a href=" + (string)url + (string)">here</a>.";

Comment on lines +932 to +938
#ifdef _WIN32
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows";
#elif defined(__APPLE__)
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac";
#else
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux";
#endif
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] These platform-specific URLs are repeated; consider centralizing them in a constant map or helper function to reduce duplication and ease future updates.

Suggested change
#ifdef _WIN32
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows";
#elif defined(__APPLE__)
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac";
#else
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux";
#endif
const char* url = get_docker_install_url();

Copilot uses AI. Check for mistakes.
@github-project-automation github-project-automation bot moved this to In progress in Client/Manager Jul 9, 2025
@AenBleidd AenBleidd added this to the Client/Manager 8.2.5 milestone Jul 9, 2025
@AenBleidd AenBleidd merged commit 1ec5848 into master Jul 9, 2025
175 checks passed
@AenBleidd AenBleidd deleted the dpa_docker19 branch July 9, 2025 08:58
@github-project-automation github-project-automation bot moved this from In progress to Merged in Client/Manager Jul 9, 2025
@davidpanderson davidpanderson restored the dpa_docker19 branch July 9, 2025 09:01
AenBleidd added a commit that referenced this pull request Jul 15, 2025
client: link to platform-specific wiki pages about Docker
@AenBleidd AenBleidd deleted the dpa_docker19 branch September 19, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants