Skip to content

client (Mac): fix Podman detection (must escape spaces in env args)#6425

Merged
AenBleidd merged 1 commit intomasterfrom
dpa_docker22
Jul 11, 2025
Merged

client (Mac): fix Podman detection (must escape spaces in env args)#6425
AenBleidd merged 1 commit intomasterfrom
dpa_docker22

Conversation

@davidpanderson
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 11, 2025 00:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the macOS Podman detection logic to correctly handle spaces in the BOINC Data directory when constructing the environment command prefix.

  • Escape spaces in the Podman data directory path string.
  • Ensure the env command prefix includes a properly formatted path.
Comments suppressed due to low confidence (2)

lib/hostinfo.cpp:381

  • The escape sequence "\ " is not a valid C string escape and will trigger a warning or unintended result. If you truly need literal backslashes, use "\ " in the string, or omit the backslashes altogether since the shell quoting around %s already handles spaces.
        const char* dir = "/Library/Application\ Support/BOINC\ Data/podman";

lib/hostinfo.cpp:386

  • [nitpick] Building complex shell commands with manual escaping can be error-prone; consider using an exec-family function with an argument array (e.g., execvp) to avoid manual quoting and improve safety.
        );

@github-project-automation github-project-automation bot moved this to In progress in Client/Manager Jul 11, 2025
@AenBleidd AenBleidd added this to the Client/Manager 8.2.5 milestone Jul 11, 2025
@AenBleidd AenBleidd merged commit d0ab0a3 into master Jul 11, 2025
175 checks passed
@AenBleidd AenBleidd deleted the dpa_docker22 branch July 11, 2025 08:17
@github-project-automation github-project-automation bot moved this from In progress to Merged in Client/Manager Jul 11, 2025
AenBleidd added a commit that referenced this pull request Jul 15, 2025
client (Mac): fix Podman detection (must escape spaces in env args)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants