client (Mac): fix Podman detection (must escape spaces in env args)#6425
Merged
client (Mac): fix Podman detection (must escape spaces in env args)#6425
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the macOS Podman detection logic to correctly handle spaces in the BOINC Data directory when constructing the environment command prefix.
- Escape spaces in the Podman data directory path string.
- Ensure the
envcommand prefix includes a properly formatted path.
Comments suppressed due to low confidence (2)
lib/hostinfo.cpp:381
- The escape sequence "\ " is not a valid C string escape and will trigger a warning or unintended result. If you truly need literal backslashes, use "\ " in the string, or omit the backslashes altogether since the shell quoting around
%salready handles spaces.
const char* dir = "/Library/Application\ Support/BOINC\ Data/podman";
lib/hostinfo.cpp:386
- [nitpick] Building complex shell commands with manual escaping can be error-prone; consider using an exec-family function with an argument array (e.g.,
execvp) to avoid manual quoting and improve safety.
);
AenBleidd
approved these changes
Jul 11, 2025
AenBleidd
added a commit
that referenced
this pull request
Jul 15, 2025
client (Mac): fix Podman detection (must escape spaces in env args)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.