Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes VirtualBox-specific download logic, refines button styling across the site, and adds safety checks around batch operations while disabling unused example RPC code.
- Drop VirtualBox code and simplify the download page to a single BOINC installer button.
- Update download buttons to use
button_styleand adjust font sizing. - Add guards against empty ID lists in batch functions and disable unused web RPC example.
- Clean up forum search button CSS classes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| html/user/download_software.php | Removed VBox logic, updated download_button signature and styling |
| html/inc/web_rpc_api.inc | Changed example block from if (1) to if (0) to disable it |
| html/inc/submit_util.inc | Wrapped abort_batch and retire_batch ID operations in if ($ids) |
| html/inc/forum.inc | Simplified forum search button class from btn btn-sm to btn |
Comments suppressed due to low confidence (2)
html/inc/submit_util.inc:287
- Initialize
$idsto an empty array before theforeachso thatif ($ids)doesn’t trigger an undefined variable notice when there are no workunits.
if ($ids) {
html/inc/submit_util.inc:321
- Initialize
$idsto an empty array before the loop inretire_batchto avoid undefined variable warnings when there are no workunits.
if ($ids) {
| } | ||
|
|
||
| if (1) { | ||
| if (0) { |
There was a problem hiding this comment.
[nitpick] Remove the unused example if (0) block entirely to clean up dead code and reduce confusion.
|
|
||
| // Can also be called as a web RPC; | ||
| // see https://github.com/BOINC/boinc/wiki/WebRpc#download | ||
| // NOT USED - OK TO REMOVE |
There was a problem hiding this comment.
[nitpick] Consider deleting the unused RPC parameter comments and definitions below as noted, since they’re no longer referenced.
AenBleidd
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.