Conversation
…Windows installer configuration Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Windows installer version script to target the correct JSON configuration file and renames its handler for clarity.
- Renames
set_boinc_jsontoset_property_json - Changes file path from
installer/boinc.jsontoinstaller/include/Property.json - Updates call site to use the new function name
Comments suppressed due to low confidence (1)
release_tools/set-client-version.py:92
- [nitpick] The function name
set_property_jsonis quite generic; consider renaming it to something more descriptive likeset_installer_product_versionto clarify its purpose.
def set_property_json(version):
Comment on lines
+93
to
+99
| with open('installer/include/Property.json','r') as f: | ||
| data = json.load(f) | ||
| for item in data['Property']: | ||
| if item['Property'] == 'ProductVersion': | ||
| item['Value'] = version | ||
| break | ||
| with open('installer/boinc.json','w') as f: | ||
| with open('installer/include/Property.json','w') as f: |
There was a problem hiding this comment.
The JSON file path is hard-coded in two places; extracting it as a top-level constant (e.g. PROPERTY_JSON_PATH) would reduce duplication and make future updates easier.
Comment on lines
95
to
97
| for item in data['Property']: | ||
| if item['Property'] == 'ProductVersion': | ||
| item['Value'] = version |
There was a problem hiding this comment.
The literal JSON keys ('Property', 'Value', 'ProductVersion') are magic strings; consider defining them as constants to avoid typos and ease maintenance.
Suggested change
| for item in data['Property']: | |
| if item['Property'] == 'ProductVersion': | |
| item['Value'] = version | |
| for item in data[PROPERTY_KEY]: | |
| if item[PROPERTY_KEY] == PRODUCT_VERSION_KEY: | |
| item[VALUE_KEY] = version |
AenBleidd
added a commit
that referenced
this pull request
Jul 15, 2025
[ci] update set-client-version.py to target correct json file of the Windows installer configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.