[ci] improve linux package fedora tests#6437
Merged
Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Fedora CI workflow to install the latest available BOINC client and manager packages dynamically rather than using a fixed version.
- Replace hardcoded
dnf installcommands with dynamic version detection for the alpha channel - Apply the same dynamic lookup for the stable channel
Comments suppressed due to low confidence (3)
.github/workflows/linux-package.yml:817
- This regex only captures the major.minor.patch portion and omits the release suffix (e.g.,
-1.fc42), which may causednf installto fail. Consider capturing the fullversion-releasestring, for example by usingdnf repoquery --queryformat '%{VERSION}-%{RELEASE}' boinc-client --repo=...or adjusting the regex accordingly.
client_version=$(dnf list --available --repo boinc-alpha-fc${{ matrix.os }} | grep boinc-client | grep -oP '\b\d+\.\d+\.\d+\b')
.github/workflows/linux-package.yml:819
- Wrap the package arguments in quotes to prevent word splitting or shell interpretation issues, for example:
dnf install -y "boinc-client-${client_version}" "boinc-manager-${manager_version}"
dnf install -y boinc-client-${client_version} boinc-manager-${manager_version}
.github/workflows/linux-package.yml:817
- [nitpick] The dynamic version lookup logic is duplicated for both alpha and stable blocks. Consider extracting this into a reusable step or using YAML anchors to reduce duplication and ease future maintenance.
client_version=$(dnf list --available --repo boinc-alpha-fc${{ matrix.os }} | grep boinc-client | grep -oP '\b\d+\.\d+\.\d+\b')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.