Skip to content

[ci] improve linux package fedora tests#6437

Merged
AenBleidd merged 1 commit intomasterfrom
vko_improve_linux_package_fedora_update_tests
Jul 15, 2025
Merged

[ci] improve linux package fedora tests#6437
AenBleidd merged 1 commit intomasterfrom
vko_improve_linux_package_fedora_update_tests

Conversation

@AenBleidd
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd AenBleidd added this to the Client/Manager 8.4.0 milestone Jul 15, 2025
Copilot AI review requested due to automatic review settings July 15, 2025 22:16
@github-project-automation github-project-automation bot moved this to In progress in Client/Manager Jul 15, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Fedora CI workflow to install the latest available BOINC client and manager packages dynamically rather than using a fixed version.

  • Replace hardcoded dnf install commands with dynamic version detection for the alpha channel
  • Apply the same dynamic lookup for the stable channel
Comments suppressed due to low confidence (3)

.github/workflows/linux-package.yml:817

  • This regex only captures the major.minor.patch portion and omits the release suffix (e.g., -1.fc42), which may cause dnf install to fail. Consider capturing the full version-release string, for example by using dnf repoquery --queryformat '%{VERSION}-%{RELEASE}' boinc-client --repo=... or adjusting the regex accordingly.
          client_version=$(dnf list --available --repo boinc-alpha-fc${{ matrix.os }} | grep boinc-client | grep -oP '\b\d+\.\d+\.\d+\b')

.github/workflows/linux-package.yml:819

  • Wrap the package arguments in quotes to prevent word splitting or shell interpretation issues, for example:
dnf install -y "boinc-client-${client_version}" "boinc-manager-${manager_version}"
          dnf install -y boinc-client-${client_version} boinc-manager-${manager_version}

.github/workflows/linux-package.yml:817

  • [nitpick] The dynamic version lookup logic is duplicated for both alpha and stable blocks. Consider extracting this into a reusable step or using YAML anchors to reduce duplication and ease future maintenance.
          client_version=$(dnf list --available --repo boinc-alpha-fc${{ matrix.os }} | grep boinc-client | grep -oP '\b\d+\.\d+\.\d+\b')

@AenBleidd AenBleidd merged commit 0d63fb2 into master Jul 15, 2025
177 checks passed
@AenBleidd AenBleidd deleted the vko_improve_linux_package_fedora_update_tests branch July 15, 2025 22:40
@github-project-automation github-project-automation bot moved this from In progress to Merged in Client/Manager Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants