Remove unfinished wasm compilation support.#6446
Merged
Conversation
Ref: #3086 (comment) Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes incomplete WebAssembly (WASM) compilation support from the BOINC project, as referenced in issue #3086. The title contains a typo ("infinished" instead of "unfinished").
- Removes all WASM-related build scripts, configuration files, and CI workflows
- Eliminates WASM-specific code from source files including conditional compilation blocks
- Cleans up deployment scripts by removing WASM client packaging functions
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wasm/*.sh | Removes all WASM build and configuration scripts |
| .github/workflows/wasm.yml | Removes WASM CI workflow |
| configure.ac | Removes --enable-wasm configuration option and related logic |
| client/hostinfo_*.cpp | Removes WASM-specific code blocks and Emscripten includes |
| deploy/prepare_deployment.py | Removes WASM client packaging functions |
| 3rdParty/vcpkg_ports/* | Removes WASM-specific vcpkg configuration files |
| Makefile.am | Removes WASM files from distclean targets |
| samples/wasm/index.html | Removes WASM sample HTML file |
| if test "${enable_wasm}" != yes ; then | ||
| AC_CHECK_HEADERS(sys/shm.h) | ||
| fi | ||
| AC_CHECK_HEADERS(sys/types.h sys/un.h arpa/inet.h dirent.h grp.h fcntl.h inttypes.h stdint.h memory.h netdb.h netinet/in.h netinet/tcp.h netinet/ether.h net/if.h net/if_arp.h signal.h strings.h sys/auxv.h sys/file.h sys/fcntl.h sys/ipc.h sys/ioctl.h sys/msg.h sys/param.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/sockio.h sys/socket.h sys/stat.h sys/statvfs.h sys/statfs.h sys/systeminfo.h sys/time.h sys/types.h sys/utsname.h sys/vmmeter.h sys/wait.h unistd.h utmp.h errno.h procfs.h ieeefp.h setjmp.h float.h sal.h execinfo.h xlocale.h) |
There was a problem hiding this comment.
The line is excessively long and difficult to read. Consider breaking this AC_CHECK_HEADERS call into multiple lines for better maintainability.
Suggested change
| AC_CHECK_HEADERS(sys/types.h sys/un.h arpa/inet.h dirent.h grp.h fcntl.h inttypes.h stdint.h memory.h netdb.h netinet/in.h netinet/tcp.h netinet/ether.h net/if.h net/if_arp.h signal.h strings.h sys/auxv.h sys/file.h sys/fcntl.h sys/ipc.h sys/ioctl.h sys/msg.h sys/param.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/sockio.h sys/socket.h sys/stat.h sys/statvfs.h sys/statfs.h sys/systeminfo.h sys/time.h sys/types.h sys/utsname.h sys/vmmeter.h sys/wait.h unistd.h utmp.h errno.h procfs.h ieeefp.h setjmp.h float.h sal.h execinfo.h xlocale.h) | |
| AC_CHECK_HEADERS( \ | |
| sys/types.h sys/un.h arpa/inet.h dirent.h grp.h fcntl.h inttypes.h stdint.h memory.h netdb.h netinet/in.h \ | |
| netinet/tcp.h netinet/ether.h net/if.h net/if_arp.h signal.h strings.h sys/auxv.h sys/file.h sys/fcntl.h \ | |
| sys/ipc.h sys/ioctl.h sys/msg.h sys/param.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/sockio.h \ | |
| sys/socket.h sys/stat.h sys/statvfs.h sys/statfs.h sys/systeminfo.h sys/time.h sys/types.h sys/utsname.h \ | |
| sys/vmmeter.h sys/wait.h unistd.h utmp.h errno.h procfs.h ieeefp.h setjmp.h float.h sal.h execinfo.h xlocale.h \ | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #3086 (comment)