Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the pinned GitHub Action used to set up the Android SDK in the Android CI workflow.
Changes:
- Bumps
android-actions/setup-androidfrom one pinned commit SHA to another in the Android workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Setup Android SDK | ||
| uses: android-actions/setup-android@651bceb6f9ca583f16b8d75b62c36ded2ae6fc9c | ||
| uses: android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699 |
There was a problem hiding this comment.
Pinned-by-SHA is good for supply-chain safety, but it’s hard to audit/track later. Consider adding an inline comment with the corresponding action release/tag (e.g., # vX.Y.Z) or a brief note referencing the upstream release/PR so future updates are easier to review.
Suggested change
| uses: android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699 | |
| uses: android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699 # SHA-pinned; record the corresponding upstream release/tag when updating this action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Update the Android CI workflow to use a newer pinned version of
android-actions/setup-android. This pulls in upstream fixes while keeping the workflow reproducible and secure.Written for commit e55e2d9. Summary will update on new commits.