boinccmd: make --get_state and --get_simple_gui_info show same task info#7092
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates BOINC’s boinccmd-related GUI RPC client printing/parsing so task details shown by --get_state and --get_simple_gui_info are aligned, addressing #7081 by ensuring both commands can show both project name and project URL for tasks.
Changes:
- Update
RESULT::print()to always print the project URL and print the project name when aPROJECT*is available. - In
get_simple_gui_info(), link each parsed<result>to its corresponding<project>by matchingresult->project_urltoproject->master_url.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/gui_rpc_client_print.cpp | Adjusts task printing to include project URL consistently (and project name when available). |
| lib/gui_rpc_client_ops.cpp | Associates results with projects during get_simple_gui_info() parsing so task printing can include project details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -150,9 +150,8 @@ void RESULT::print() { | |||
| printf(" WU name: %s\n", wu_name); | |||
| if (project) { | |||
AenBleidd
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7081
Summary by cubic
Aligns boinccmd --get_state and --get_simple_gui_info so they show the same task info, including consistent project details. Fixes #7081.
Written for commit e92f991. Summary will update on new commits. Review in cubic