Skip to content

Fix Infer Contrast #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChanceSauley wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Infer Contrast #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae7bc5
ENH: Git ignore MacOS generated .DS_STORE files
ChanceSauley Jan 16, 2026
d375a17
BUG: fix infer_contrast() when the tag was missing
ChanceSauley Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,3 +549,6 @@ dmypy.json

# End of https://www.toptal.com/developers/gitignore/api/visualstudiocode
**/__pycache__/**

# MacOS generated files
.DS_STORE
5 changes: 4 additions & 1 deletion src/dcm_classifier/image_type_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,10 @@ def infer_contrast(self, feature_dict: dict = None) -> bool:
return False

# check if the volume has contrast
if "none" not in feature_dict[field].lower():
if (
"none" not in feature_dict[field].lower()
and feature_dict[field] != "-12345"
):
return True
return False

Expand Down
3 changes: 3 additions & 0 deletions ...data/anonymized_testing_data/contrast_data/without_contrast/no_contrastbolusagent_tag.dcm
View file
Open in desktop
Git LFS file not shown
4 changes: 2 additions & 2 deletions tests/testing_data/integration_testing/classify_study_data/output.json
View file
Open in desktop
Git LFS file not shown
4 changes: 3 additions & 1 deletion tests/unit_testing/test_dicom_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,9 @@ def test_dcm_series_no_contrast(no_contrast_file_path):
study.run_inference()

for series_number, series in study.series_dictionary.items():
assert series.get_has_contrast() is False
assert (
series.get_has_contrast() is False
), f"File {series.get_volume_list()[0].get_one_volume_dcm_filenames()[0].name} came back with contrast"


def test_dcm_series_has_contrast(contrast_file_path):
Expand Down
Loading