feat: improve visit command#37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way delays are handled in network request mocking and the
visitcommand. The main improvement is the replacement of a locally definedsleepfunction with a sharedwaitutility, and the extraction of thevisitlogic into its own module for better code reuse and clarity.Refactoring and Code Reuse:
sleepfunction inmockBridge.tswith the sharedwaitutility for consistent delay handling across the codebase. (src/commands/mockBridge.ts) [1] [2] [3] [4]visitlogic into a newvisitcommand module, which now includes a delay using the sharedwaitutility and improved logging. (src/commands/visit.ts,src/twd.ts) [1] [2] [3]This closes #30