Fix/select testing library#89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across the codebase, focusing on enhanced test coverage, UI refinements, and more robust proxying of DOM queries. The most significant changes include adding new tests for sidebar functionality and the Vite plugin, improving DOM query scoping to exclude the sidebar, and updating UI styling for a more consistent look.
Testing improvements:
TWDSidebar) to verify rendering of total, passed, and failed test counts, as well as the ability to run individual tests via the UI.removeMockServiceWorker) by mocking filesystem and path modules, and adding cases for both successful and failed file removals. [1] [2]DOM proxy and query updates:
screenDomproxy to scope queries within the main app container, excluding the sidebar, ensuring that queries likegetByTextandqueryByTextdo not select elements from the sidebar.selector: "h1"option fromgetByTextandqueryByTextcalls, reflecting the new proxy behavior. [1] [2]screenDomproxy to include property accesses such aslogTestingPlaygroundURLandprettyDOM.UI and styling enhancements:
#1A6EF4), and refined padding and border styles for improved layout. [1] [2] [3]These changes collectively improve the reliability of tests, the accuracy of DOM queries, and the usability and appearance of the UI.