Skip to content

Fix/select testing library#89

Merged
kevinccbsg merged 5 commits into
mainfrom
fix/select-testing-library
Nov 14, 2025
Merged

Fix/select testing library#89
kevinccbsg merged 5 commits into
mainfrom
fix/select-testing-library

Conversation

@kevinccbsg

Copy link
Copy Markdown
Member

This pull request introduces several improvements across the codebase, focusing on enhanced test coverage, UI refinements, and more robust proxying of DOM queries. The most significant changes include adding new tests for sidebar functionality and the Vite plugin, improving DOM query scoping to exclude the sidebar, and updating UI styling for a more consistent look.

Testing improvements:

  • Added tests for the sidebar (TWDSidebar) to verify rendering of total, passed, and failed test counts, as well as the ability to run individual tests via the UI.
  • Enhanced tests for the Vite plugin (removeMockServiceWorker) by mocking filesystem and path modules, and adding cases for both successful and failed file removals. [1] [2]

DOM proxy and query updates:

  • Updated the screenDom proxy to scope queries within the main app container, excluding the sidebar, ensuring that queries like getByText and queryByText do not select elements from the sidebar.
  • Adjusted tests to remove the selector: "h1" option from getByText and queryByText calls, reflecting the new proxy behavior. [1] [2]
  • Expanded test coverage for the screenDom proxy to include property accesses such as logTestingPlaygroundURL and prettyDOM.

UI and styling enhancements:

  • Updated button and sidebar header background colors for a more unified look (#1A6EF4), and refined padding and border styles for improved layout. [1] [2] [3]
  • Changed the color of the "View rules in console" text for better visibility.
  • Added a summary row to the sidebar displaying the total number of tests, as well as counts for passed and failed tests, with color-coded icons.

These changes collectively improve the reliability of tests, the accuracy of DOM queries, and the usability and appearance of the UI.

@kevinccbsg kevinccbsg merged commit 7b2ed30 into main Nov 14, 2025
5 checks passed
@kevinccbsg kevinccbsg deleted the fix/select-testing-library branch November 14, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant