Add metadata-precheck module to validate SFTP metadata excels upfront#816
Draft
Aberdur wants to merge 8 commits intoBU-ISCIII:developfrom
Draft
Add metadata-precheck module to validate SFTP metadata excels upfront#816Aberdur wants to merge 8 commits intoBU-ISCIII:developfrom
Aberdur wants to merge 8 commits intoBU-ISCIII:developfrom
Conversation
saramonzon
reviewed
Nov 12, 2025
Member
saramonzon
left a comment
There was a problem hiding this comment.
Docstrings are left, use same docstring format than other modules
SchemaMapper can be used in other modules? Should it be put in utils?
saramonzon
reviewed
Nov 12, 2025
| class SchemaMapper: | ||
| """Keep all header normalisation + casting logic encapsulated for reuse and readability.""" | ||
|
|
||
| SAMPLE_FALLBACKS = [ |
Member
There was a problem hiding this comment.
in the code should be no labels, only properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Example
PR Checklist
black and flake8).CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).