Skip to content

read-lab-metadata: keep submitting_institution_id from metadata in EQA initial-config#868

Merged
Aberdur merged 5 commits intoBU-ISCIII:developfrom
Aberdur:develop
Feb 26, 2026
Merged

read-lab-metadata: keep submitting_institution_id from metadata in EQA initial-config#868
Aberdur merged 5 commits intoBU-ISCIII:developfrom
Aberdur:develop

Conversation

@Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Feb 26, 2026

PR Description

This PR makes submitting_institution_id override configurable in read-lab-metadata.

Changes

  • Added new config flag in read_lab_metadata:
    • force_submitting_institution_id_from_lab_code (default: true)
  • Updated read_lab_metadata logic to only set submitting_institution_id from lab_code when that flag is enabled.
  • Set force_submitting_institution_id_from_lab_code: false in initial_config-EQA2026.yaml.

PR Checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

self.required_post_processing = (
self.project_config.get("required_post_processing", {}) or {}
)
self.force_submitting_institution_id_from_lab_code = bool(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool() is redundant here, isn't it?

@Aberdur Aberdur merged commit b2a538a into BU-ISCIII:develop Feb 26, 2026
5 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants