corner cases in _read_str, _read_int and _read_float #50
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks so much for the contribution! The type hinting with the I also need to figure out why all the tests are failing. I'm working on a few major updates and look forward to getting this sorted out shortly Thanks again for finding this and fixing it. |
Contributor
|
I am leaning towards supporting Python >3.9 for numpy 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses corner cases found in existing snirf datasets.
_read_strcan handle strings that are stored as arrays of bytes_read_[str,float,int]can handle empty datasets (this addresses Crash when validating data entries with 0 length #49)