Skip to content

KHR_materials_volume_scatter import#17194

Draft
MiiBond wants to merge 2 commits intoBabylonJS:masterfrom
MiiBond:mbond/KHR_materials_volume_scatter
Draft

KHR_materials_volume_scatter import#17194
MiiBond wants to merge 2 commits intoBabylonJS:masterfrom
MiiBond:mbond/KHR_materials_volume_scatter

Conversation

@MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Sep 24, 2025

This isn't at all a full implementation of this WIP extension as the PBRMaterial doesn't have the ability to render SSS in the way expected by the extension. And I haven't started implementing transparency or subsurface in OpenPBRMaterial yet...

However, I think this provides a good starting point for future support in OpenPBRMaterial as it adds the appropriate properties in the material adapter and does the needed conversion to OpenPBR-compatible parameters from glTF.

@MiiBond MiiBond marked this pull request as draft September 24, 2025 23:40
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@github-actions
Copy link

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label Oct 24, 2025
@MiiBond MiiBond force-pushed the mbond/KHR_materials_volume_scatter branch from 7c13529 to 8e6228b Compare October 27, 2025 16:12
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2025

@deltakosh
Copy link
Contributor

Hey @MiiBond
Just fyi, we are really close to code freeze for v9.0 so I would love to merge that one :)

@thomlucc thomlucc added this to the 10.0 milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants