-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[WebGPU-XR] Check XRGPUBinding before native fallback #18711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sebavan
merged 1 commit into
BabylonJS:master
from
rebeckerspecialties:codex/webxr-layers-capability-order
Jul 21, 2026
+117
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /** | ||
| * @vitest-environment jsdom | ||
| */ | ||
|
|
||
| import { NullEngine } from "core/Engines/nullEngine"; | ||
| import { Scene } from "core/scene"; | ||
| import { WebXRLayers } from "core/XR/features/WebXRLayers"; | ||
| import { WebXRSessionManager } from "core/XR/webXRSessionManager"; | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; | ||
|
|
||
| interface ProjectionLayerBindingConstructor { | ||
| prototype: { | ||
| createProjectionLayer?: () => void; | ||
| }; | ||
| } | ||
|
|
||
| type TestGlobals = typeof globalThis & { | ||
| XRGPUBinding?: ProjectionLayerBindingConstructor; | ||
| XRWebGLBinding?: ProjectionLayerBindingConstructor; | ||
| }; | ||
|
|
||
| describe("WebXRLayers", () => { | ||
| let engine: NullEngine; | ||
| let scene: Scene; | ||
| let sessionManager: WebXRSessionManager; | ||
| const testGlobals = globalThis as TestGlobals; | ||
| let originalGPUBinding: ProjectionLayerBindingConstructor | undefined; | ||
| let originalWebGLBinding: ProjectionLayerBindingConstructor | undefined; | ||
|
|
||
| beforeEach(() => { | ||
| engine = new NullEngine({ | ||
| renderHeight: 256, | ||
| renderWidth: 256, | ||
| textureSize: 256, | ||
| deterministicLockstep: false, | ||
| lockstepMaxSteps: 1, | ||
| }); | ||
| scene = new Scene(engine); | ||
| sessionManager = new WebXRSessionManager(scene); | ||
| originalGPUBinding = testGlobals.XRGPUBinding; | ||
| originalWebGLBinding = testGlobals.XRWebGLBinding; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| if (originalGPUBinding) { | ||
| testGlobals.XRGPUBinding = originalGPUBinding; | ||
| } else { | ||
| delete testGlobals.XRGPUBinding; | ||
| } | ||
| if (originalWebGLBinding) { | ||
| testGlobals.XRWebGLBinding = originalWebGLBinding; | ||
| } else { | ||
| delete testGlobals.XRWebGLBinding; | ||
| } | ||
| vi.restoreAllMocks(); | ||
| scene.dispose(); | ||
| engine.dispose(); | ||
| }); | ||
|
|
||
| function setEnvironment(isNative: boolean, isWebGPU: boolean): void { | ||
| vi.spyOn(sessionManager, "isNative", "get").mockReturnValue(isNative); | ||
| vi.spyOn(engine, "isWebGPU", "get").mockReturnValue(isWebGPU); | ||
| } | ||
|
|
||
| function installGPUBinding(): void { | ||
| const binding = vi.fn() as unknown as ProjectionLayerBindingConstructor; | ||
| binding.prototype.createProjectionLayer = vi.fn(); | ||
| testGlobals.XRGPUBinding = binding; | ||
| } | ||
|
|
||
| function installWebGLBinding(): void { | ||
| const binding = vi.fn() as unknown as ProjectionLayerBindingConstructor; | ||
| binding.prototype.createProjectionLayer = vi.fn(); | ||
| testGlobals.XRWebGLBinding = binding; | ||
| } | ||
|
|
||
| describe("isCompatible", () => { | ||
| it("accepts native WebGPU when XRGPUBinding exposes projection layers", () => { | ||
| setEnvironment(true, true); | ||
| installGPUBinding(); | ||
|
|
||
| expect(new WebXRLayers(sessionManager).isCompatible()).toBe(true); | ||
| }); | ||
|
|
||
| it("rejects native WebGPU when XRGPUBinding is absent", () => { | ||
| setEnvironment(true, true); | ||
| delete testGlobals.XRGPUBinding; | ||
|
|
||
| expect(new WebXRLayers(sessionManager).isCompatible()).toBe(false); | ||
| }); | ||
|
|
||
| it("keeps native WebGL on the legacy render-target path", () => { | ||
| setEnvironment(true, false); | ||
| installWebGLBinding(); | ||
|
|
||
| expect(new WebXRLayers(sessionManager).isCompatible()).toBe(false); | ||
| }); | ||
|
|
||
| it("accepts browser WebGPU when XRGPUBinding exposes projection layers", () => { | ||
| setEnvironment(false, true); | ||
| installGPUBinding(); | ||
|
|
||
| expect(new WebXRLayers(sessionManager).isCompatible()).toBe(true); | ||
| }); | ||
|
|
||
| it("accepts browser WebGL when XRWebGLBinding exposes projection layers", () => { | ||
| setEnvironment(false, false); | ||
| installWebGLBinding(); | ||
|
|
||
| expect(new WebXRLayers(sessionManager).isCompatible()).toBe(true); | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.