Skip to content

Nightly (#8761) #8762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Nightly (#8761) #8762

merged 1 commit into from
Aug 18, 2020

Conversation

deltakosh
Copy link
Contributor

  • Expose feature points in BabylonJS as a native extension.

  • Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature

  • Add some comments and minor cleanup

  • Fix some minor spacing issues

  • Add id to feature point data.

  • fix indexing of confidence value and ID.

  • Maintain feature point cloud across frames, signal with our collection every frame.

  • Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames.

  • Fix doubled size array from doing both a distinct size declaration and .push.

  • Add in doc describing implementation of FeaturePoints into LibDeclarations.

  • Cleanup, make exposed array readonly and use private member variable to do internal accounting.

  • Updating What's new, and move private member variable to unbreak typedoc.

  • Apply suggestions from code review

Co-authored-by: Ryan Tremblay [email protected]

Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle)

Co-authored-by: Alejandro Toledo [email protected]

Stencil state is takes from the engine (or overridden)

  • KTX2 transcoders (KTX2 transcoders #8760)

  • Fix potential recursive calls

  • Add the ktx2 transcoders

  • Nightly

  • Nightly

Co-authored-by: Alex Tran [email protected]
Co-authored-by: Ryan Tremblay [email protected]
Co-authored-by: Raanan Weber [email protected]
Co-authored-by: Gary Hsu [email protected]
Co-authored-by: Popov72 [email protected]
Co-authored-by: aWeirdo [email protected]
Co-authored-by: Alejandro Toledo Martinez [email protected]
Co-authored-by: Alejandro Toledo [email protected]

* Expose feature points in BabylonJS as a native extension.

* Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature

* Add some comments and minor cleanup

* Fix some minor spacing issues

* Add id to feature point data.

* fix indexing of confidence value and ID.

* Maintain feature point cloud across frames, signal with our collection every frame.

* Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames.

* Fix doubled size array from doing both a distinct size declaration and .push.

* Add in doc describing implementation of FeaturePoints into LibDeclarations.

* Cleanup, make exposed array readonly and use private member variable to do internal accounting.

* Updating What's new, and move private member variable to unbreak typedoc.

* Apply suggestions from code review

Co-authored-by: Ryan Tremblay <[email protected]>

* Address PR comments.  Split feature point updates into added, and updated.

* Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled.

* Optional entity types array for XR hit-test

* Address PR comments.

* Make feature names readonly.

* Make it so ids do not need to be sequential.

* Add option in default pipeline property grid to convert cc to gamma or linear

* Nightly

* Nightly

* Update KHR_materials_variants to latest spec (#8739)

* remove reset button for variants

* Fix thin instance bounding info computation (#8740)

* Nightly

* Add some precision to the doc of onMeshLoaded callback / observable (#8743)

* Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748)

* fix updateOptions issue (#8746)

* Optional entity types array for XR hit-test

* fix updateOptions issue

* linting

* remove unneeded character

* 4.2.0-alpha.33

* Update sphereBuilder.ts (#8750)

* Update sphereBuilder.ts

Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle)

* Update what's new.md (#12)

* Update sphereBuilder.ts

* Fix linting

* expose overlay, add css class

* say what say waht say what is new (what is new!)

* Update webXREnterExitUI.ts

* [XR] Make sure any model will work with the controller loop (#8758)

* Optional entity types array for XR hit-test

* defensively dealing with missing valueMesh (thou unlikely)

* Fix playground examples loading (#8756)

* Optional entity types array for XR hit-test

* Fix example-loading issues

* Flat tangent (#8751)

* Flat tangent

* Whats new

* whats new

Co-authored-by: Alejandro Toledo <[email protected]>

* [XR] WebXR Hand Tracking - initial support (#8753)

* Optional entity types array for XR hit-test

* hand tracking declaration

* depends on and hand tracking name

* defensive

* added the hand tracking feature

* nuwat

* fix non-supporting-system issue

* make sure model is disposedif the controller is already disposed

* disable pointer selection for hand tracking

* new observers, physics config

* documentation

* linting

* code doc

* fixing the d.ts issue

* extends instead of implements

* Fix potential recursive calls (#8757)

* nightly

* [XR] Setting default values for the XR creation context (#8759)

Stencil state is takes from the engine (or overridden)

* KTX2 transcoders (#8760)

* Fix potential recursive calls

* Add the ktx2 transcoders

* Nightly

* Nightly

Co-authored-by: Alex Tran <[email protected]>
Co-authored-by: Ryan Tremblay <[email protected]>
Co-authored-by: Raanan Weber <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Popov72 <[email protected]>
Co-authored-by: aWeirdo <[email protected]>
Co-authored-by: Alejandro Toledo Martinez <[email protected]>
Co-authored-by: Alejandro Toledo <[email protected]>
@deltakosh deltakosh merged commit 405a1e0 into master Aug 18, 2020
deltakosh added a commit that referenced this pull request Aug 18, 2020
* Expose feature points in BabylonJS as a native extension.

* Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature

* Add some comments and minor cleanup

* Fix some minor spacing issues

* Add id to feature point data.

* fix indexing of confidence value and ID.

* Maintain feature point cloud across frames, signal with our collection every frame.

* Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames.

* Fix doubled size array from doing both a distinct size declaration and .push.

* Add in doc describing implementation of FeaturePoints into LibDeclarations.

* Cleanup, make exposed array readonly and use private member variable to do internal accounting.

* Updating What's new, and move private member variable to unbreak typedoc.

* Apply suggestions from code review

Co-authored-by: Ryan Tremblay <[email protected]>

* Address PR comments.  Split feature point updates into added, and updated.

* Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled.

* Optional entity types array for XR hit-test

* Address PR comments.

* Make feature names readonly.

* Make it so ids do not need to be sequential.

* Add option in default pipeline property grid to convert cc to gamma or linear

* Nightly

* Nightly

* Update KHR_materials_variants to latest spec (#8739)

* remove reset button for variants

* Fix thin instance bounding info computation (#8740)

* Nightly

* Add some precision to the doc of onMeshLoaded callback / observable (#8743)

* Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748)

* fix updateOptions issue (#8746)

* Optional entity types array for XR hit-test

* fix updateOptions issue

* linting

* remove unneeded character

* 4.2.0-alpha.33

* Update sphereBuilder.ts (#8750)

* Update sphereBuilder.ts

Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle)

* Update what's new.md (#12)

* Update sphereBuilder.ts

* Fix linting

* expose overlay, add css class

* say what say waht say what is new (what is new!)

* Update webXREnterExitUI.ts

* [XR] Make sure any model will work with the controller loop (#8758)

* Optional entity types array for XR hit-test

* defensively dealing with missing valueMesh (thou unlikely)

* Fix playground examples loading (#8756)

* Optional entity types array for XR hit-test

* Fix example-loading issues

* Flat tangent (#8751)

* Flat tangent

* Whats new

* whats new

Co-authored-by: Alejandro Toledo <[email protected]>

* [XR] WebXR Hand Tracking - initial support (#8753)

* Optional entity types array for XR hit-test

* hand tracking declaration

* depends on and hand tracking name

* defensive

* added the hand tracking feature

* nuwat

* fix non-supporting-system issue

* make sure model is disposedif the controller is already disposed

* disable pointer selection for hand tracking

* new observers, physics config

* documentation

* linting

* code doc

* fixing the d.ts issue

* extends instead of implements

* Fix potential recursive calls (#8757)

* nightly

* [XR] Setting default values for the XR creation context (#8759)

Stencil state is takes from the engine (or overridden)

* KTX2 transcoders (#8760)

* Fix potential recursive calls

* Add the ktx2 transcoders

* Nightly

* Nightly

* Nightly (#8761) (#8762)

* Expose feature points in BabylonJS as a native extension.

* Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature

* Add some comments and minor cleanup

* Fix some minor spacing issues

* Add id to feature point data.

* fix indexing of confidence value and ID.

* Maintain feature point cloud across frames, signal with our collection every frame.

* Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames.

* Fix doubled size array from doing both a distinct size declaration and .push.

* Add in doc describing implementation of FeaturePoints into LibDeclarations.

* Cleanup, make exposed array readonly and use private member variable to do internal accounting.

* Updating What's new, and move private member variable to unbreak typedoc.

* Apply suggestions from code review

Co-authored-by: Ryan Tremblay <[email protected]>

* Address PR comments.  Split feature point updates into added, and updated.

* Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled.

* Optional entity types array for XR hit-test

* Address PR comments.

* Make feature names readonly.

* Make it so ids do not need to be sequential.

* Add option in default pipeline property grid to convert cc to gamma or linear

* Nightly

* Nightly

* Update KHR_materials_variants to latest spec (#8739)

* remove reset button for variants

* Fix thin instance bounding info computation (#8740)

* Nightly

* Add some precision to the doc of onMeshLoaded callback / observable (#8743)

* Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748)

* fix updateOptions issue (#8746)

* Optional entity types array for XR hit-test

* fix updateOptions issue

* linting

* remove unneeded character

* 4.2.0-alpha.33

* Update sphereBuilder.ts (#8750)

* Update sphereBuilder.ts

Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle)

* Update what's new.md (#12)

* Update sphereBuilder.ts

* Fix linting

* expose overlay, add css class

* say what say waht say what is new (what is new!)

* Update webXREnterExitUI.ts

* [XR] Make sure any model will work with the controller loop (#8758)

* Optional entity types array for XR hit-test

* defensively dealing with missing valueMesh (thou unlikely)

* Fix playground examples loading (#8756)

* Optional entity types array for XR hit-test

* Fix example-loading issues

* Flat tangent (#8751)

* Flat tangent

* Whats new

* whats new

Co-authored-by: Alejandro Toledo <[email protected]>

* [XR] WebXR Hand Tracking - initial support (#8753)

* Optional entity types array for XR hit-test

* hand tracking declaration

* depends on and hand tracking name

* defensive

* added the hand tracking feature

* nuwat

* fix non-supporting-system issue

* make sure model is disposedif the controller is already disposed

* disable pointer selection for hand tracking

* new observers, physics config

* documentation

* linting

* code doc

* fixing the d.ts issue

* extends instead of implements

* Fix potential recursive calls (#8757)

* nightly

* [XR] Setting default values for the XR creation context (#8759)

Stencil state is takes from the engine (or overridden)

* KTX2 transcoders (#8760)

* Fix potential recursive calls

* Add the ktx2 transcoders

* Nightly

* Nightly

Co-authored-by: Alex Tran <[email protected]>
Co-authored-by: Ryan Tremblay <[email protected]>
Co-authored-by: Raanan Weber <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Popov72 <[email protected]>
Co-authored-by: aWeirdo <[email protected]>
Co-authored-by: Alejandro Toledo Martinez <[email protected]>
Co-authored-by: Alejandro Toledo <[email protected]>

Co-authored-by: Alex Tran <[email protected]>
Co-authored-by: Ryan Tremblay <[email protected]>
Co-authored-by: Raanan Weber <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Popov72 <[email protected]>
Co-authored-by: aWeirdo <[email protected]>
Co-authored-by: Alejandro Toledo Martinez <[email protected]>
Co-authored-by: Alejandro Toledo <[email protected]>

Co-authored-by: Alex Tran <[email protected]>
Co-authored-by: Ryan Tremblay <[email protected]>
Co-authored-by: Raanan Weber <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Popov72 <[email protected]>
Co-authored-by: aWeirdo <[email protected]>
Co-authored-by: Alejandro Toledo Martinez <[email protected]>
Co-authored-by: Alejandro Toledo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant