Bugfix: Correct file name matching on Windows#553
Merged
Bachmann1234 merged 1 commit intoBachmann1234:mainfrom Nov 11, 2025
Merged
Bugfix: Correct file name matching on Windows#553Bachmann1234 merged 1 commit intoBachmann1234:mainfrom
Bachmann1234 merged 1 commit intoBachmann1234:mainfrom
Conversation
Owner
|
Change looks reasonable to me. Ill have to find some time this week to fix the CI build. |
amos-chen
changed the title
Contributor
Author
|
@Bachmann1234 Thanks for the review! |
Owner
|
Alrighty, lets merge this! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes file matching on Windows where
src_pathis lowercased byos.path.normcase(), butfile_name(from the JaCoCo XML) retains its original casing. This mismatch caused thesrc_path.endswith(file_name)check to fail and report no coverage.