-
Notifications
You must be signed in to change notification settings - Fork 500
null #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jdeandrade22
wants to merge
31
commits into
Baekalfen:master
Choose a base branch
from
isabellarussell26:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
null #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Create a new *Directory* named "roms" and load all .gb's into it -run game_launcher.py
Create game_launcher.py
…ch frame- issue 217
…ding, Rom directory, screen recording, adjusting volume.
…rder with Sound - Implemented sound extraction API and screen recorder with synchronized audio. Added documentation and test files. Pair programmed by Jordan and Bella Russell
…S. Linux/Mac yet to be implemented
…test files - Add GitHub Actions workflow for GUI tests - Add test requirements and documentation - Add comprehensive test suite for game launcher
# Conflicts: # game_launcher.py # test_217_sound_extraction_api.py # test_368_screen_recorder_with_sound.py
…and test_settings_window_iniitialization pass.
…and test_settings_window_iniitialization pass.
… same key twice, windows render relative to main window's location, keybind options are limited to ease implementation with SDL2 key mappings
…p test_game_launcher.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an error for a college project, please disregard<!--
Type an explanation of what feature your code adds or which bug it fixes.
Checklist for pull-requests
So make sure you have read and understand it.
It's a shame to make something big that doesn't fit the project.
getting your pull-request ready.
pip install pre-commit
. This takes care of the formatting rules when you commit your code.-->