fix: prevent UI freeze when running post-commands#17
Merged
Conversation
- run post-commands with 5 second timeout using context.WithTimeout - wait for commands to complete before quitting on user request - add WaitingForCommands state with waiting screen on quit - cancel running commands immediately when user confirms next action Fixes #16
Bahaaio
changed the title
Bahaaio
changed the title
Bahaaio
changed the title
Bahaaio
force-pushed
the
fix/post-command-timeout
branch
from
cf79306 to
f548574
Compare
Bahaaio
added a commit
that referenced
this pull request
Mar 13, 2026
previously, when onSessionEnd was start, actions wouldn't run, now they will run in the background, with the same 5 second timeout see #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-commands (then) previously blocked the UI until they finished, causing the app to freeze.
They now run in the background with a timeout, and pomo stays responsive throughout.
Changes
onSessionEnd: "ask")Waiting Screen
Fixes #16