Skip to content

Conversation

@Heena31
Copy link

@Heena31 Heena31 commented Jun 20, 2025

Fixed Bug from the Ticket : BAH-3997 | Fix. Bump Java 8 -> 17 #40

rahu1ramesh and others added 2 commits July 4, 2024 09:16
Dependecy Versions have been updated to resolve security vulnerabilities
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2025

CLA assistant check
All committers have signed the CLA.

@Heena31 Heena31 changed the title Bah 4998 Bah 4998 HI | Fix. Bump Java 8 -> 17 Jun 20, 2025
@Heena31 Heena31 changed the title Bah 4998 HI | Fix. Bump Java 8 -> 17 Bah 4998 | Fix. Bump Java 8 -> 17 Jun 20, 2025
@mohan-13
Copy link
Member

@Heena31 Thanks for your contribution.
I tried a local build using your changes, but I could not see the liquibase migrations being run and the database schema is not created. Please take a look

@Heena31
Copy link
Author

Heena31 commented Jul 7, 2025

@mohan-13 We found a way to fix the issue regarding schema not coming up in the database. Kindly check the updates and let us know.

@rahu1ramesh
Copy link
Contributor

Thank you for taking the initiative to migrate the repository from Java 8 to Java 17—this is a much-needed update and greatly appreciated.

That said, I would recommend approaching the migration in two stages:
first from Java 8 to Java 11, and then from Java 11 to Java 17.

The rationale for this suggestion is as follows:

  • Incremental Upgrade Path: Java 11 is the next LTS version after Java 8 and introduces several changes (e.g., module system, removal of deprecated APIs, var keyword) that are easier to test and validate when isolated from Java 17-specific concerns.
  • Improved Debuggability: By isolating issues to a specific version jump, we can more easily pinpoint and resolve potential compatibility or behavioral changes.
  • Review Simplicity: Reviewing a single major version upgrade at a time makes it easier to trace regressions or unintended side effects, especially in areas involving libraries, build tooling, or runtime dependencies.
  • Standard Practice: This staged approach aligns with common migration strategies recommended in Java ecosystem documentation and helps minimize risk.

Could you please revise the PR to reflect a two-step migration—first to Java 11, with associated build and code adjustments—and then raise a follow-up PR for the move from Java 11 to Java 17?

Happy to assist in reviewing each step thoroughly. Thank you again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants