BAH-4391 | Add. Mapping for mandatory fields in Hl7 message for DCM4CHEE 5 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angshu
approved these changes
Nov 27, 2025
| pid.getAdministrativeSex().setValue(openMRSPatient.getGender()); | ||
|
|
||
| message.getORDER().getORDER_DETAIL().getOBR().getPlannedPatientTransportComment(0).getText().setValue(openMRSPatient.getGivenName()+","+openMRSPatient.getFamilyName()); | ||
| message.getORDER().getORDER_DETAIL().getOBR().getPlannedPatientTransportComment(0).getText().setValue(openMRSPatient.getGivenName() + "," + openMRSPatient.getFamilyName()); |
Member
There was a problem hiding this comment.
I think one improvement we can do (maybe later, is to localize the name. eg family, given
Member
Author
There was a problem hiding this comment.
Sure! Will note it down on a card
| @Component | ||
| public class StudyInstanceUIDGeneratorImpl implements StudyInstanceUIDGenerator { | ||
|
|
||
| @Value("${study.instance.uid.prefix:1.2.826.0.1.3680043.8.498}") |
Member
There was a problem hiding this comment.
is there no additional miliseconds part? is it always fixed?
Member
Author
There was a problem hiding this comment.
This is the base UID specific to the org. We will be appending hash code of order number
| } | ||
|
|
||
| @Test | ||
| public void shouldGenerateStudyInstanceUIDWithPrefixandOrderNumberHash() { |
Member
There was a problem hiding this comment.
To assert that for a given order number (ORD-317), the same studyinstanceid is generated - writing another test case would be nice
… UID by Order Number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the mandatory mappings that are required by DCM4CHEE 5 to receive and process HL7 ORM Messages and convert them to DICOM MWL.
Following are the changes:
Message Header
Patient Demographics
MR. Can be overriden by HL7_PATIENT_IDENTIFIR_TYPE_CODEORC
Adds custom ZDS block to generate and set StudyInstanceUID.
OBR
Adds Placer Field 1 with Order Number. Shows as Accession Number in DCM4CHEE
This change is backward compatiblw with dcm4chee 2.x also, since these mappings are part of orm2dcm.xsl which is not needed for now
DCM4CHEE 2.5.x
DCM4CHEE 5.33.1