-
Notifications
You must be signed in to change notification settings - Fork 56
[BIP-875] Implement EZKL Dynamic Fee Control for Balancer Pools #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Xeonus
commented
Sep 25, 2025
- Proposal
- permissions granting as per BIP specs for mainnet and base
- [Proposal](https://forum.balancer.fi/t/bip-xxx-implement-ezkl-dynamic-fee-control-for-balancer-pools/6836) - permissions granting as per BIP specs for mainnet and base
|
FILENAME:
FILENAME:
FILENAME:
FILENAME:
FILENAME:
|
|
FILENAME: FILENAME: FILENAME: FILENAME: FILENAME: |
… reports) + reformat JSON
|
@gosuto-inzasheru we would like to queue this to snapshot today. Can you do an initial review before that? Thanks |
|
Given fee helper v2 is in the works this needs more clarity: balancer/balancer-deployments#309 |
… reports) + reformat JSON
jubeira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Necessary governance permissions are in place; only one pool is being added to one set (BAL V2 / mainnet / wstETH-AAVE). Assuming initial manager is correct, although the set can be restored if required without governance by the maxi omni.
New sets can be created by the maxi omni later on without governance intervention.
| "initialManager": "0xB7aadD330A64088A85e500874DCDcFB7F253fEB4", | ||
| "newPoolIds": "[0x3de27efa2f1aa663ae5d458857e731c129069f29000200000000000000000588]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wstETH / AAVE in V2 from weighted pool V4: https://balancer.fi/pools/ethereum/v2/0x3de27efa2f1aa663ae5d458857e731c129069f29000200000000000000000588 ✔️
| }, | ||
| "transactions": [ | ||
| { | ||
| "to": "0x809B79b53F18E9bc08A961ED4678B901aC93213a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authorizer ✔️
| }, | ||
| "transactions": [ | ||
| { | ||
| "to": "0x8A8B9f35765899B3a0291700141470D79EA2eA88", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BAL v2 swap fee helper ✔️
| "payable": false | ||
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x82082fa8e750c32535c8828ada82d6f47fd7ec82740773fc3bb3f7eb88a11717]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setSwapFeePercentage for weighted pool V4.
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x82082fa8e750c32535c8828ada82d6f47fd7ec82740773fc3bb3f7eb88a11717]", | ||
| "account": "0xd22eecBB495380Ef52b1CCeF1cA594979885D484" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bal v2 swap fee helper ✔️
| "payable": false | ||
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set static swap fee percentage (bal v3)
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]", | ||
| "account": "0xFc00536A0fd292c284deeF6af8F644d8373d9cad" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pool helper (bal v3)
| }, | ||
| "transactions": [ | ||
| { | ||
| "to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authorizer
| "payable": false | ||
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set static swap fee percentage (bal v3)
| }, | ||
| "contractInputsValues": { | ||
| "roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]", | ||
| "account": "0xc00fF743B73346c9a4C40509e0550FfC18e5426d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pool swap fee helper (bal v3)