Skip to content

Conversation

@Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Sep 25, 2025

  • Proposal
  • permissions granting as per BIP specs for mainnet and base

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

FILENAME: BIPs/2025-W41/BIP-875-create_ezkl_poolset.json
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W41/BIP-875-v2-fee-helper-perms-base.json
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W41/BIP-875-v2-fee-helper-perms-mainnet.json
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W41/BIP-875-v3-fee-helper-perms-base.json
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W41/BIP-875-v3-fee-helper-perms-mainnet.json
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

FILENAME: BIPs/2025-W41/BIP-875-v2-fee-helper-perms-base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                     | caller_address                             | fx_paths                                                             | action_ids                                                         |   bip   | tx_index |
+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250919-pool-swap-fee-helper/PoolSwapFeeHelper | 0xd22eecBB495380Ef52b1CCeF1cA594979885D484 | 20230320-weighted-pool-v4/WeightedPool/setSwapFeePercentage(uint256) | 0x82082fa8e750c32535c8828ada82d6f47fd7ec82740773fc3bb3f7eb88a11717 | BIP-875 |    0     |
+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W41/BIP-875-v2-fee-helper-perms-mainnet.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                     | caller_address                             | fx_paths                                                             | action_ids                                                         |   bip   | tx_index |
+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250919-pool-swap-fee-helper/PoolSwapFeeHelper | 0x8A8B9f35765899B3a0291700141470D79EA2eA88 | 20220908-weighted-pool-v2/WeightedPool/setSwapFeePercentage(uint256) | 0x78e9adfe5f05d7114a59d0870d78971192f871f57bb36e2aff2edbe75d425844 | BIP-875 |    0     |
|                       |                                                 |                                            | 20230206-weighted-pool-v3/WeightedPool/setSwapFeePercentage(uint256) | 0xd8638fc873fb8c5c0e67c437099a19eb0546fb439dab8babff44196f11d44831 |         |          |
|                       |                                                 |                                            | 20230320-weighted-pool-v4/WeightedPool/setSwapFeePercentage(uint256) | 0xa5547190e3d59f2bfeb4174ca3454b2f2acaeed644bc7ad7018014516f73f2bd |         |          |
+-----------------------+-------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W41/BIP-875-v3-fee-helper-perms-base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                           | caller_address                             | fx_paths                                                                 | action_ids                                                         |   bip   | tx_index |
+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250919-v3-pool-swap-fee-helper-v2/PoolSwapFeeHelper | 0xFc00536A0fd292c284deeF6af8F644d8373d9cad | 20241204-v3-vault/VaultAdmin/setStaticSwapFeePercentage(address,uint256) | 0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c | BIP-875 |    0     |
+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W41/BIP-875-v3-fee-helper-perms-mainnet.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                           | caller_address                             | fx_paths                                                                 | action_ids                                                         |   bip   | tx_index |
+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250919-v3-pool-swap-fee-helper-v2/PoolSwapFeeHelper | 0xc00fF743B73346c9a4C40509e0550FfC18e5426d | 20241204-v3-vault/VaultAdmin/setStaticSwapFeePercentage(address,uint256) | 0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c | BIP-875 |    0     |
+-----------------------+-------------------------------------------------------+--------------------------------------------+--------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W41/BIP-875-create_ezkl_poolset.json
MULTISIG: multisigs/maxi_omni (mainnet:0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e)
COMMIT: 3e8e819c6042b3f289f5d2c7fa61940fe2cffd5d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+---------------+----------------------------------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+
| fx_name       | to                                                                                           | value | inputs                                                                   | bip_number | tx_index |
+---------------+----------------------------------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+
| createPoolSet | 0x8A8B9f35765899B3a0291700141470D79EA2eA88 (20250919-pool-swap-fee-helper/PoolSwapFeeHelper) | 0     | {                                                                        | BIP-875    |   N/A    |
|               |                                                                                              |       |   "initialManager": [                                                    |            |          |
|               |                                                                                              |       |     "0xB7aadD330A64088A85e500874DCDcFB7F253fEB4 (N/A)"                   |            |          |
|               |                                                                                              |       |   ],                                                                     |            |          |
|               |                                                                                              |       |   "newPoolIds": [                                                        |            |          |
|               |                                                                                              |       |     "0x3de27efa2f1aa663ae5d458857e731c129069f29000200000000000000000588" |            |          |
|               |                                                                                              |       |   ]                                                                      |            |          |
|               |                                                                                              |       | }                                                                        |            |          |
+---------------+----------------------------------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+

@Xeonus
Copy link
Collaborator Author

Xeonus commented Sep 26, 2025

@gosuto-inzasheru we would like to queue this to snapshot today. Can you do an initial review before that? Thanks

@Xeonus Xeonus marked this pull request as draft September 26, 2025 11:47
@Xeonus
Copy link
Collaborator Author

Xeonus commented Sep 26, 2025

Given fee helper v2 is in the works this needs more clarity: balancer/balancer-deployments#309

@Xeonus Xeonus requested a review from mikebmikeb October 2, 2025 06:51
@Xeonus Xeonus marked this pull request as ready for review October 2, 2025 07:04
@Xeonus Xeonus requested a review from zekraken-bot October 2, 2025 07:34
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Necessary governance permissions are in place; only one pool is being added to one set (BAL V2 / mainnet / wstETH-AAVE). Assuming initial manager is correct, although the set can be restored if required without governance by the maxi omni.

New sets can be created by the maxi omni later on without governance intervention.

Comment on lines +35 to +36
"initialManager": "0xB7aadD330A64088A85e500874DCDcFB7F253fEB4",
"newPoolIds": "[0x3de27efa2f1aa663ae5d458857e731c129069f29000200000000000000000588]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"transactions": [
{
"to": "0x809B79b53F18E9bc08A961ED4678B901aC93213a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorizer ✔️

},
"transactions": [
{
"to": "0x8A8B9f35765899B3a0291700141470D79EA2eA88",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAL v2 swap fee helper ✔️

"payable": false
},
"contractInputsValues": {
"roles": "[0x82082fa8e750c32535c8828ada82d6f47fd7ec82740773fc3bb3f7eb88a11717]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setSwapFeePercentage for weighted pool V4.

},
"contractInputsValues": {
"roles": "[0x82082fa8e750c32535c8828ada82d6f47fd7ec82740773fc3bb3f7eb88a11717]",
"account": "0xd22eecBB495380Ef52b1CCeF1cA594979885D484"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bal v2 swap fee helper ✔️

"payable": false
},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set static swap fee percentage (bal v3)

},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]",
"account": "0xFc00536A0fd292c284deeF6af8F644d8373d9cad"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pool helper (bal v3)

},
"transactions": [
{
"to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorizer

"payable": false
},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set static swap fee percentage (bal v3)

},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c]",
"account": "0xc00fF743B73346c9a4C40509e0550FfC18e5426d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pool swap fee helper (bal v3)

@gosuto-inzasheru gosuto-inzasheru merged commit 69c12fa into main Oct 7, 2025
3 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the BIP-875-ezkl-perms branch October 7, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants