fix: mask escaped strings properly #670
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a string in the content contains a single escaped double quote, the masking of the string fails in the CSP Nonce handler. This results in an issue with the following parts of the string, causing issues like #667
Types of changes
Description
I updated the regex so it matches only true double quotes after the opening quotes. Escaped quotes
\"are now included in the placeholder content.Resolves #667
Checklist: