Organize static functions by declaring module #2554
+334
−358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private functions declared in a library module are no longer required to be in the module namespace (see 5.18 Function Declarations). The corresponding check can be adapted easily, but the management of static functions in the
StaticFuncsclass currently mixes functions from all modules without taking into account where they were declared. As a result, it is not possible to use the same private function name in multiple modules.This PR
Tests for this have been added in
ModuleTest.functionVisibility.