-
Notifications
You must be signed in to change notification settings - Fork 1.2k
improve GATT for bluetooth, improve performance, stability for ble transport #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
improve GATT for bluetooth, improve performance, stability for ble transport #3457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the GATT transport layer to improve performance and stability by aggregating smaller packets into larger ones before sending. While the approach is sound, I've identified three critical bugs in the implementation. These include an incorrect buffer space check that could lead to overflows, faulty error handling when reading from the queue, and an incorrect payload length calculation that would cause data truncation. These issues must be fixed to ensure the correctness and stability of the BLE transport.
|
@0xkelvin man, thank you. where are you based? I'd like to send you and omi + fpc cable so you can freely dev/test, no blocker. |
|
@beastoin I am base in Singapore, let me DM you on Discord for my address |
|
i see, will send you one @0xkelvin the speed is good. btw: 1/ does your changes change the structure of the audio packet? that requires the mobile app's updates. pls note the structure of the packet before | after. actually the #3432 relates to the storage syncs (check storage.c) but not real time audio sync (pusher) |
|
@beastoin |
|
take your time, masked as draft fn, lmk once it is ready |


should be: ~30KB/s - for #3432
Gatt performance improved, so it should be solved this issue as well : #2782
Please help to test again in your side