Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Resolve "[PermissionRequestInProgressException]" when a… #1425

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

mikolashka
Copy link
Contributor

@mikolashka mikolashka commented Jan 15, 2025

fix(android): Resolve "[PermissionRequestInProgressException]" when app is relaunched with non-standard launchMode
Fixes an issue where relaunching the app after hiding it, when launchMode is not set to standard, would throw a "[PermissionRequestInProgressException] A request for permissions is already running" error.

Now ensures proper handling of permission requests when the app is relaunched.

This is issue on this bug.

…pp is relaunched with non-standard launchMode

Fixes an issue where relaunching the app after hiding it, when `launchMode` is not set to `standard`, would throw a "[PermissionRequestInProgressException] A request for permissions is already running" error.

Now ensures proper handling of permission requests when the app is relaunched.
@mikolashka
Copy link
Contributor Author

mikolashka commented Jan 23, 2025

@mvanbeusekom could you review it please?

@0ttik
Copy link

0ttik commented Feb 17, 2025

@mvanbeusekom , Hello! Could you, please, follow up on this PR. It's a small fix which covers important use case for projects having non-standard launch modes.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikolashka,

Could you please update the version number of the package in the pubspec.yaml and add a matching record in the CHANGELOG.md

@mikolashka
Copy link
Contributor Author

@mvanbeusekom, done

@0ttik
Copy link

0ttik commented Mar 1, 2025

@mvanbeusekom, hi! sorry to bother, but it looks like all required changes are done by @mikolashka, would it be possible to merge this?

@mikolashka
Copy link
Contributor Author

Hi @mvanbeusekom,

I hope you're doing well! I just wanted follow up on my Pull Request. I’ve been keeping it up to date by resolving merge conflicts whenever there are updates to the main branch, and I’d be happy to address any feedback or additional changes if needed.

I really appreciate the work you and the team are doing on this project—it’s been a great resource! Please let me know if there’s anything I can do to help move this PR forward or if it’s waiting on something specific.

Thanks so much for your time and consideration!

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikolashka,

The changes look good to me. Sorry for the long delay, I'll make sure this is published today.

Thank you very much for all the patience and effort to keep everything in sync.

@mvanbeusekom mvanbeusekom merged commit 753824b into Baseflow:main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants