Skip to content

Commit 4e49f8e

Browse files
committed
clean up
1 parent fd71465 commit 4e49f8e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

predicators/approaches/pp_param_learning_approach.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def learn_from_offline_dataset(self, dataset: Dataset) -> None:
8989
def _learn_process_parameters(
9090
self,
9191
dataset: Dataset,
92-
num_steps: int = 500,
92+
num_steps: int = 200,
9393
lr: float = 5e-2,
9494
use_lbfgs: bool = True,
9595
) -> None:
@@ -210,8 +210,8 @@ def _closure() -> float: # LBFGS expects a float return
210210
self._set_process_parameters(proc_params.detach())
211211

212212
# construct guide dictionary (softmax per ground process instance) -----
213-
guide: Dict[_GroundCausalProcess,
214-
Dict[int, Tensor]] = defaultdict(dict)
213+
guide: Dict[_GroundCausalProcess, Dict[int,
214+
Tensor]] = defaultdict(dict)
215215
current_q_param_idx = 0
216216
for gp_instance_tuple in process_instances:
217217
gp, start_t = gp_instance_tuple
@@ -268,7 +268,7 @@ def _closure() -> float: # LBFGS expects a float return
268268
if use_lbfgs:
269269
optimiser.step(_closure)
270270
else:
271-
for _ in pbar: # type: ignore[arg-type]
271+
for _ in pbar:
272272
loss = _closure()
273273
optimiser.step()
274274

predicators/ground_truth_models/boil/processes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ def get_processes(
447447
if CFG.boil_use_constant_delay:
448448
# Using the active value from original code for FillJug
449449
delay_distribution = ConstantDelay(7)
450-
delay_distribution = ConstantDelay(4)
450+
# delay_distribution = ConstantDelay(4)
451451
elif CFG.boil_use_normal_delay:
452452
delay_distribution = GaussianDelay(mean=4, std=0.2, rng=rng)
453453
elif CFG.boil_use_cmp_delay:

0 commit comments

Comments
 (0)