Fix race condition in email output generation - #290
Draft
Shotte wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in the email output generation of
check-updates.sh.The update check output is written through asynchronous
teeprocess substitutions. TheEXITtrap may inspect and sendmail-outputbefore these processes have finished writing, resulting in empty or incomplete email notifications.Changes
check-outputthrough oneteeprocess.mail-outputsynchronously from the completedcheck-output.EMAIL_USER.Validation
Tested on:
pve-manager9.2.5Before the change:
After the change:
The generated email contained the complete update summary after the change.
Validation performed:
The syntax check completed successfully.
Fixes #289