Extending tests with shellspec unit suite - #1615
Open
cedwards wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
I assume the warning tests are due to executing on GitHub actions Ubuntu environment. They all pass when I Confirmed: it's the difference between BSD sed and GNU sed. Fixing. |
| with: | ||
| usesh: true | ||
| prepare: | | ||
| pkg install -y git |
Collaborator
There was a problem hiding this comment.
git-lite will be faster here, unless there is any reason to have the bloated git
Contributor
Author
There was a problem hiding this comment.
Sure, I can change this.
Collaborator
There was a problem hiding this comment.
Maybe even git-tiny
Collaborator
|
My only comment would be to first go through the duplicated functions and try to merge them, and also decide on a standard naming convention for functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces shellspec unit test suites that allow us to better validate function behavior.
These changes have been integrated with the new lib/ structure and call specific lib files to test only those bits.
75 tests have been defined and validated. More are pending following some function re-structuring (to be discussed separately).