Skip to content

Fix/eventcount #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juneymf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/eventcount #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d9cd5b
added escape for userdefinedphenotype in eventcountphenotype
juneymf Dec 2, 2025
29ed52e
black
juneymf Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions phenex/phenotypes/event_count_phenotype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,14 @@ def __init__(

def _execute(self, tables) -> PhenotypeTable:
# Execute the child phenotype to get the initial table to filter
if self.phenotype.return_date != "all":
raise ValueError(
"EventCountPhenotype requires that return_date is set to all on its component phenotype"
)
# if not a UserDefinedPhenotype, ensure that all dates are returned
if self.phenotype.__class__.__name__ != "UserDefinedPhenotype":

if self.phenotype.return_date != "all":
raise ValueError(
"EventCountPhenotype requires that return_date is set to all on its component phenotype"
)

table = self.phenotype.table

# Select only distinct dates:
Expand Down