Versions of algorithms implementing tighter LB update and other improvements #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleaned the code * added prunning of distance calculations in kmeans++ using center-center distances * removed the old version of kmeans++
* the comments needs to be done
* the elkan algorithm has one TODO
* there are still many modifications that need to be finished in other
variants
triangle_based_kmeans_neighbors in order to remove code duplicates
(and not the modified udpate)
…5secs for bigD2.txt dataset)
relative to the center movement
|
@petrrysavy can you provide a class hierarchy for all the algorithms (including the original set)? |
| /* This function claculated inner product of two vectors of dimension d. | ||
| * The number of inner products is counted in the superclass. | ||
| */ | ||
| virtual inline double inner_product(double *a, double const *b) { |
There was a problem hiding this comment.
Why is b const and a is not? And why is this function not const?
|
The class hierarchy: |
modified_update_triangle_based_kmeans
|
I have ported this code over to ghamerly/fast-kmeans#1 and am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.