Fix/821 match error rendering error pages #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal solution for #821
What Is aw in my dev environment is that conn.private.phoenix_live_view extra session value is set as 3 items tuple, instead of a map, as expected. Not sure if this changed some where in the past and is actually expected.
I can't figure it out clearly what was going on, and why the session is expected as a map, every test I did, returned as a tuple, not sure if this was a change on LiveView itself, I didn't research much from that side.
Hopefully you have time to review this and clarify if needed (I am using this branch for my working site as I need this custom error pages to work), If there is an alternative, I will appreciate it