Skip to content

feat: TimeInput size variants, addons, and locale-aware hourCycle #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ntatoud wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: TimeInput size variants, addons, and locale-aware hourCycle #693

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
afd75bf
feat: add size variants, addons, and locale-aware hourCycle to TimeInput
ntatoud Feb 20, 2026
74291eb
fix: apply md:text-base to inputs and controls for lg InputGroup size
ntatoud Feb 20, 2026
7708c74
fix: move control text-size from base to per-variant to avoid CSS con…
ntatoud Feb 20, 2026
a254efd
Revert "fix: move control text-size from base to per-variant to avoid…
ntatoud Feb 20, 2026
5350c04
refactor: use useLocale from react-aria-components instead of react-i…
ntatoud Feb 20, 2026
a3609ae
refactor: expose plain TimeValue object API, keep @internationalized/…
ntatoud Feb 20, 2026
e5ccfa8
docs: add FromDate story showing TimeValue from Date and dayjs
ntatoud Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"@better-upload/server": "3.0.12",
"@fontsource-variable/inter": "5.2.8",
"@hookform/resolvers": "5.2.2",
"@internationalized/date": "^3.11.0",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Pin new dependencies to exact versions for consistency.

Every other dependency in package.json uses exact version pinning (no ^ or ~). Using caret ranges on @internationalized/date and react-aria-components is inconsistent and can allow unintended minor/patch updates during pnpm update runs.

📦 Suggested fix 
-    "@internationalized/date": "^3.11.0",
+    "@internationalized/date": "3.11.0",
-    "react-aria-components": "^1.15.1",
+    "react-aria-components": "1.15.1",

Also applies to: 88-88

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 52, The package.json contains caret-pinned dependencies
"@internationalized/date" and "react-aria-components" which is inconsistent with
the rest of the file; change both entries to exact versions (remove the leading
"^" and replace with the specific version number to match the lockstyle used
elsewhere) so dependency versions are fully pinned and deterministic (update the
values for the "@internationalized/date" and "react-aria-components" entries).

"@orpc/client": "1.13.4",
"@orpc/openapi": "1.13.4",
"@orpc/react-query": "1.13.4",
Expand Down Expand Up @@ -84,6 +85,7 @@
"pino-pretty": "13.1.3",
"prettier": "3.8.1",
"react": "19.2.4",
"react-aria-components": "^1.15.1",
"react-day-picker": "9.13.0",
"react-dom": "19.2.4",
"react-error-boundary": "6.1.0",
Expand Down
Loading
Loading