fix(translate): escape special character % to prevent crash #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtomasicchio
approved these changes
Feb 18, 2025
qtomasicchio
requested changes
Feb 18, 2025
| const translatedResult = sprintf(translation, { ...data, ...i18nNames, number }); | ||
| // escape special characters (% for now) | ||
| const translationValues = _mapValues({ ...data, ...i18nNames, number }, value => { | ||
| if (value) { |
There was a problem hiding this comment.
According to the unit test, value can be a number. We should probably check that we have a string, what do you think?
Suggested change
| if (value) { | |
| if (typeof value === 'string') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
I saw an error with one of my preview for EPG and the root cause was the title of the box contained the "%" chars.
Because of this char, the sprintf command failed.
t('my_translation_string%')does not work(In fact, in my original case, the "translation string" is not really a translation key but an already translated key like
t('Mon super programme 100% cool')💻 How?
Escape the "%" chars to prevent sprintf command to crash.