fix: cover edge cases for anchor tags #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13433032158Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 13414773993Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 13414773993Details
💛 - Coveralls |
flepretre
reviewed
Feb 20, 2025
Comment on lines
22
to
30
| it('should validate anchor with static href value', () => { | ||
| expect(validateHTML({ validAnchor: '<a href="http://localhost">foo</a>' }, 'test', true)).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('should validate anchor with interpolated href value', () => { | ||
| expect( | ||
| validateHTML({ validAnchor: '<a href="%(googlePrivacyUrl)s">Règles de confidentialité</a>' }, 'test', true), | ||
| ).toMatchSnapshot(); | ||
| }); |
There was a problem hiding this comment.
results are empty arrays, maybe we don't need snapshot
There was a problem hiding this comment.
Yeah, I tried to keep the same structure as the test above, to have some consistency, but maybe I can just have it check the error object to be false
There was a problem hiding this comment.
Changed it to check for the array lenght to be zero
flepretre
approved these changes
Feb 20, 2025
yfrommelt
approved these changes
Feb 21, 2025
dbs-ced
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
At bedrock we want to add translations with a static href value and the current linter never captures the open anchor tag.
eg: 'some link' will fail because it won't have a open tag captured
How?
Add a second capture group just for this case