Skip to content

fix(setup): reuse existing uv-created venv instead of failing on rerun #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Turkzilla wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

fix(setup): reuse existing uv-created venv instead of failing on rerun #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions run-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,31 @@ setup_environment() {
rm -rf "$VENV_PATH"
fi

# Reuse an existing uv-created venv if its Python is still valid.
# `uv venv` refuses to write into an existing directory without --clear,
# so without this branch every run after the first one fails with
# "A virtual environment already exists" and falls back to system
# Python detection — defeating the uv-first design.
if [[ -d "$VENV_PATH" ]] && [[ -f "$VENV_PATH/uv_created" ]]; then
local existing_python
if existing_python=$(get_venv_python_path "$VENV_PATH") && [[ -x "$existing_python" ]]; then
print_success "Reusing existing uv environment ($($existing_python --version 2>&1))"
if ! $existing_python -m pip --version &>/dev/null 2>&1; then
Comment on lines +596 to +597
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable $existing_python should be double-quoted when used as a command to prevent word splitting and globbing. This is particularly important if the path to the virtual environment contains spaces, which is common on some operating systems (e.g., macOS or Windows).

Suggested change
print_success "Reusing existing uv environment ($($existing_python --version 2>&1))"
if ! $existing_python -m pip --version &>/dev/null 2>&1; then
print_success "Reusing existing uv environment ($("$existing_python" --version 2>&1))"
if ! "$existing_python" -m pip --version &>/dev/null 2>&1; then

print_info "Installing pip in uv environment..."
if bootstrap_pip "$existing_python" "python3"; then
print_success "pip installed in uv environment"
else
print_warning "Failed to install pip in uv environment"
fi
fi
echo "$existing_python"
return 0
fi
# Marker present but Python is missing/broken — start clean.
print_warning "uv-created venv looks broken, recreating"
rm -rf "$VENV_PATH"
fi

# Try Python 3.12 first (preferred)
local uv_output
if uv_output=$(uv venv --python 3.12 "$VENV_PATH" 2>&1); then
Expand Down
Loading