Conversation
| "autoload-dev": { | ||
| "psr-4": { | ||
| "Tests\\Behat\\": "tests/Behat/" | ||
| "Tests\\": "tests/" |
There was a problem hiding this comment.
This helps:
- IDEs (e.g. PhpStorm or IDEA) correctly detect the tests directory as the "tests root"
- It decrease the wtf factor if someone adds test classes elsewhere which wouldn't load otherwise
- It may not be the best, performance-wise, but I think it's not so critical seeing as it only impacts tests (i.e.
composer --dev).
There was a problem hiding this comment.
My proposal would be to flatten the tests folder (thanks to PSR-4 possibilities) but keeping a prefix that enforce using a proper namespace of that library (I would even use Tests\Behat\Gherkin as prefix)
There was a problem hiding this comment.
I wouldn't be against it, but then it does become a bit inconsistent with src:
(although I suppose we can do it for src too - is a change in filesystem structure considered a BC break?)
There was a problem hiding this comment.
it is not a BC break (assuming you update the autoload config to be valid for the new path), unless your project requires users to hardcode a path to a file inside your package (which is not the case for Gherkin)
|
@stof all points that have been raised are solved, anything else to move forward on this PR? |
Roll back "yield from" to "return".
3 participants
No description provided.