Improve tag handling; update test#289
Merged
acoulton merged 3 commits intoBehat:masterfrom Feb 26, 2025
Merged
Conversation
stof
reviewed
Feb 24, 2025
acoulton
approved these changes
Feb 26, 2025
carlos-granados
approved these changes
Feb 26, 2025
Contributor
carlos-granados
left a comment
carlos-granados
left a comment
There was a problem hiding this comment.
Looks good, thanks @uuf6429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a new feature, but rather a small improvement on tag handling.
Here's what changed:
hasTag/hasTagscode is always the same, so I moved it into a trait (that depends on abstract methodgetTags).ExampleTableNodenow implementsTaggedNodeInterfaceand the new trait - I couldn't see why it wouldn't have that in the first placeIt would have been nice to move
getTagsto the trait too, but at this PHP level we can't define abstract properties or property requirements, so I think this is the safest and cleanest approach at the moment.