Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
=========================================
Coverage 95.83% 95.83%
Complexity 667 667
=========================================
Files 44 44
Lines 1921 1921
=========================================
Hits 1841 1841
Misses 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
| a future major release. By @stof in [#350](https://github.com/Behat/Gherkin/pull/350) | ||
| * Introduce configurable `GherkinCompatibilityMode` to control how gherkin files are parsed. In the default `legacy` mode, | ||
| there is no change to parsing. In the new **experimental** `gherkin-32` mode, files will be parsed consistently with the | ||
| official cucumber/gherkin parsers. In this first release of the new mode: |
There was a problem hiding this comment.
Maybe this should be updated to mention that files are not yet parsed entirely like the upstream parser as long as this mode is experimental.
There was a problem hiding this comment.
Good point - I think it's clearer now?
| - Invalid language tags will cause an exception by @stof in [#357](https://github.com/Behat/Gherkin/pull/357) | ||
| - Step keywords will not be trimmed by @stof in [#360](https://github.com/Behat/Gherkin/pull/360) | ||
| - Language tags can include whitespace by @acoulton in [#358](https://github.com/Behat/Gherkin/pull/358) | ||
| - `\n` literals in table cells will be parsed as newlines by @stof in [#359](https://github.com/Behat/Gherkin/pull/359) |
There was a problem hiding this comment.
I would suggest merging #391 and including it in the same release, as I discovered that the wrong handling of escaping in table cells could lead to some issues there. An escaped backslash follow by a n would start being broken by that change, while it was parsed fine before.
|
@stof now updated with the additional changes now merged for this release. |
2 participants
@carlos-granados @stof there was more unreleased than I had remembered from just before the summer...
I think we should release what we have now - we have documented in the CHANGELOG and the class itself that there are further changes planned for the
GherkinCompatibilityModeso I don't think we need to be blocked by that.This will also allow us to test / add PHP 8.5 support in Behat/Behat.