test: Fix cucumber variant assertions to include inherited properties#394
Merged
acoulton merged 1 commit intoBehat:masterfrom Nov 6, 2025
Merged
Conversation
Most of our nodes are standalone classes, but ExampleTableNode inherits from TableNode and the actual `table` content is a private property in the parent class. This meant that our dumped YAML data for assertions did not capture the example table content. I built this commit off the original (based on 4.14.0) and then patched it onto the current version - only one original feature was affected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
=========================================
Coverage 95.86% 95.86%
Complexity 669 669
=========================================
Files 44 44
Lines 1934 1934
=========================================
Hits 1854 1854
Misses 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acoulton
commented
Nov 6, 2025
| 17: | ||
| - color | ||
| 18: | ||
| - "\_ \tred\_ \t" |
Contributor
Author
There was a problem hiding this comment.
I'm already aware of the padding variation - there's a skipped cucumber example for it but we didn't have an issue so have opened #395
stof
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our nodes are standalone classes, but ExampleTableNode inherits from TableNode and the actual
tablecontent is a private property in the parent class. This meant that our dumped YAML data for assertions did not capture the example table content.I built this commit off the original (based on 4.14.0) and then patched it onto the current version - only one original feature was affected.