Skip to content

fix: Add Stringable to classes implementing __toString() #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoulton merged 1 commit into from
Dec 2, 2025
Merged

fix: Add Stringable to classes implementing __toString() #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Node/PyStringNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@

namespace Behat\Gherkin\Node;

use Stringable;

/**
* Represents Gherkin PyString argument.
*
* @author Konstantin Kudryashov <ever.zet@gmail.com>
*
* @final since 4.15.0
*/
class PyStringNode implements ArgumentInterface
class PyStringNode implements Stringable, ArgumentInterface
{
/**
* @param list<string> $strings String in form of [$stringLine]
Expand Down
5 changes: 3 additions & 2 deletions src/Node/TableNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Iterator;
use IteratorAggregate;
use ReturnTypeWillChange;
use Stringable;

/**
* Represents Gherkin Table argument.
Expand All @@ -23,7 +24,7 @@
*
* @template-implements IteratorAggregate<int, array<string, string>>
*/
class TableNode implements ArgumentInterface, IteratorAggregate
class TableNode implements Stringable, ArgumentInterface, IteratorAggregate
{
/**
* @var array<array-key, int>
Expand Down Expand Up @@ -135,7 +136,7 @@ public function getColumnsHash()

$hash = [];
foreach ($rows as $row) {
\assert($keys !== null); // If there is no first row due to an empty table, we won't enter this loop either.
assert($keys !== null); // If there is no first row due to an empty table, we won't enter this loop either.
$hash[] = array_combine($keys, $row);
}

Expand Down