Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Selenium2 driver to accept unexpectedAlertBehavior option #338

Open
pawel-grzona wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Selenium2 driver to accept unexpectedAlertBehavior option #338

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32c3559
Selenium2 configuration to accept unexpectedAlertBehavior option
pawel-grzona Apr 27, 2017
78a9789
Update composer.json
pawel-grzona Apr 27, 2017
7d4f0cf
Update composer.json
pawel-grzona Apr 27, 2017
69c35f3
Update Selenium2Factory.php
pawel-grzona Apr 28, 2017
38e9638
Removed default value of the unexpectedAlertBehavior option of Seleni…
pawel-grzona Dec 12, 2018
65ef905
Update version packages
pawel-grzona Sep 28, 2021
837d0ec
Update composer.json
pawel-grzona Sep 28, 2021
3ddee7e
Merge branch 'master' of https://github.com/GForces-PL/MinkExtension
pawel-grzona Nov 24, 2021
b4131be
Merge origin in; resolve conflicts
pawel-grzona May 17, 2022
43a46c5
Merge origin in; resolve conflicts
pawel-grzona May 17, 2022
c4d3fbb
Update goutte driver factory
pawel-grzona May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Behat/MinkExtension/ServiceContainer/Driver/Selenium2Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ protected function getCapabilitiesNode()
->addDefaultsIfNotSet()
->normalizeKeys(false)
->children()
->scalarNode('unexpectedAlertBehaviour')->defaultValue('ignore')->end()
Copy link
Member

@stof stof Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we put no default value, as done for others. We rely on Selenium's default for most of them (especially given that different implementations might support different ones)

Copy link
Author

@pawel-grzona pawel-grzona Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense, I will change it.
Thanks for the review :)

What about the Travis failures below? They don't seem to be related to my change?

->scalarNode('browserName')->end()
->scalarNode('version')->end()
->scalarNode('platform')->end()
Expand Down